Separate year to year hardware with drive chassis#425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
We’ve been running into a lot of duplicate code in our ElectricalContract system, especially when it comes to checking whether each subsystem or motor is ready. Right now, adding a new motor often requires defining multiple isXXXReady functions across different files, which is repetitive and hard to maintain. This change is intended to better separate year-specific hardware, like the shooter we used this season, from more stable, evergreen components such as cameras and the drive chassis.
Asana task URL:
Whats changing?
Questions/notes for reviewers
How this was tested
Video/screenshots (from simulator or live robot)
PR feedback legend